Repository navigation
fix(chat): timestamp return delivery after verification - #8311
Open
loopx-agent wants to merge 1 commit into
Open
loopx-agent wants to merge 1 commit into
loopx-agent wants to merge 1 commit into
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The return worker captured one timestamp at the start of each drain. A provider verification that finished later could produce a delivery receipt with
delivered_atset to the start of the drain.Change
Keep one cutoff for scanning eligible returns and read the clock again for each delivery transaction. Callers supplying
nowstill get a fixed clock. The restart recovery test verifies the completion time and keeps the assertion that the provider is not sent a second reply.Validation
python -m pytest -q tests/test_manager_context_roundtrip.pypassed all 118 tests on the fix.git diff --checkpassed.