Skip to content

Exercise genuinely partial Goal attention in the packaged smoke #8301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loopx-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −11
Open

Exercise genuinely partial Goal attention in the packaged smoke #8301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions examples/personal-workspace-browser/goal-masthead.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,20 +240,16 @@ export const goalMastheadScenario = {
await quiet.close();
throw error;
}
// The canonical producer retains 21 open decisions and bounds its overview
// to three. Pass its payload through the shipped parser
// and adapter, rather than manufacturing a complete three-item queue.
// The canonical producer supplies 21 open rows and a three-row overview.
// Use the real rows and counts for both complete and partial coverage.
const fixtureEnv = { ...process.env, LOOPX_USAGE_PING: "0" };
if (!["LOOPX_TEST_PYTHON", "LOOPX_PYTHON_BIN", "LOOPX_PYTHON"].some(key => process.env[key])) fixtureEnv.PYTHONPATH = repoRoot;
const native = JSON.parse(execFileSync(resolveTestPython(), [
resolve(repoRoot, "examples/personal-workspace-browser/goal-attention-fixture.py"),
], { cwd: repoRoot, env: fixtureEnv, encoding: "utf8", timeout: 30_000 }));
const nativeCase = (...args) => JSON.parse(execFileSync(resolveTestPython(), [
resolve(repoRoot, "examples/personal-workspace-browser/goal-attention-fixture.py"), ...args,
], { cwd: repoRoot, env: fixtureEnv, encoding: "utf8", timeout: 30_000 }));
const native = nativeCase();
const mixed = nativeCase("--mixed");
const complete = nativeCase("--full");
const mixedComplete = nativeCase("--mixed", "--full");
const optionalComplete = nativeCase("--optional", "--full");
// Exercise source -> parser -> adapter -> digest -> packaged rendering.
// Counts are removed from a real producer payload, not a prebuilt UI model.
Expand Down Expand Up @@ -317,13 +313,19 @@ export const goalMastheadScenario = {
api.transformStatus = (fixture) => {
previous(fixture);
const queue = fixture.attention_queue.items.find(item => item.goal_id === goalId);
const source = mode === "mixed" ? mixed : mode === "complete" ? complete
: mode === "mixed-complete" ? mixedComplete : mode === "optional" ? optionalComplete : native;
const source = mode === "mixed" || mode === "mixed-complete" ? mixed
: mode === "complete" ? complete : mode === "optional" ? optionalComplete : native;
Object.assign(queue, structuredClone(source));
if (mode === "empty") {
// A complete top-level queue wins even if the overview is bounded.
// For a partial queue retain only the producer's three listed IDs.
if (mode === "mixed" || mode === "unknown") {
const listed = new Set(queue.project_asset.user_todos.items.map(todo => todo.todo_id));
queue.user_todos.items = queue.user_todos.items.filter(todo => listed.has(todo.todo_id));
}
if (mode === "bounded" || mode === "empty") {
queue.user_todos.items = [];
queue.project_asset.user_todos.items = [];
}
if (mode === "empty") queue.project_asset.user_todos.items = [];
if (mode === "unknown") {
delete queue.user_todos.open_count;
delete queue.project_asset.user_todos.open;
Expand All @@ -342,6 +344,7 @@ export const goalMastheadScenario = {
if (partial) assert.match(coverageHelp, locale === "en" ? /oldest unknown/ : /最早时间未知/);
const listed = ["complete", "mixed-complete", "optional"].includes(mode) ? 21 : mode === "empty" ? 0 : 3;
if (partial) assert.match(coverageHelp, new RegExp(`${listed} ${locale === "en" ? "listed" : "项"}`));
if (mode === "mixed-complete") assert.match(needs.sub, locale === "en" ? /20 optional/ : /20 项可选/);
if (mode === "optional") assert.match(needs.sub, locale === "en" ? /21 optional/ : /21 项可选/);
if (mode === "unknown") assert.doesNotMatch(needs.sub, /Nothing waiting|暂无等待/);
await ui.page.getByRole("navigation", { name: /^(Goal 视图|Goal view)$/ }).getByRole("button", { name: /^(概览|Overview)$/ }).click();
Expand Down
Loading