Skip to content

Limit work context planning to selection facts #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangruiteng wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −2
Open

Limit work context planning to selection facts #8295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion loopx/control_plane/work_items/context_readback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,20 @@ def attach_work_context(payload: dict[str, Any], *, registry_path: Path,
agent_id = (payload.get("agent_identity") or {}).get("agent_id")
if not goal_id:
return
plan = effect_runtime_result("work_item.context.plan", {"packet": payload})
# The typed planner needs the selection inputs, not the admission body
# that the public reader and final capture continue to own.
cli = interaction.get("cli_channel")
orchestration = payload.get("task_orchestration_contract")
plan = effect_runtime_result("work_item.context.plan", {"packet": {
"selected_todo": packet_selected,
"effective_action": payload.get("effective_action"),
"task_orchestration_contract": {
key: orchestration.get(key) for key in ("schema_version", "mode", "primary_todo_id")
} if isinstance(orchestration, dict) else {},
"interaction_contract": {"cli_channel": {
"selection_required": cli.get("selection_required"),
} if isinstance(cli, dict) else {}},
}})
selected = plan.get("selected_todo")
if isinstance(selected, dict) and isinstance(selected_text_snapshot, str):
selected["_context_text_sha256"] = selected_text_snapshot
Expand Down
16 changes: 15 additions & 1 deletion tests/control_plane/test_work_acceptance_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,16 +166,30 @@ def cli(*arguments):
def unavailable(**_kwargs):
raise OSError("acceptance source unavailable")

planner_sources = []
runtime_result = context_readback.effect_runtime_result

def observe_planner_source(method, params, **options):
if method == "work_item.context.plan":
planner_sources.append(params["packet"])
return runtime_result(method, params, **options)

with monkeypatch.context() as fault:
fault.setattr(context_readback, "inspect_goal_acceptance", unavailable)
fault.setattr(context_readback, "effect_runtime_result", observe_planner_source)
output = io.StringIO()
with contextlib.redirect_stdout(output):
code = main(["--registry", str(registry), "--runtime-root", str(runtime), "--format", "json",
"quota", "should-run", "--goal-id", goal, "--agent-id", "agent-a", ])
"quota", "should-run", "--goal-id", goal, "--agent-id", "agent-a", "--context-delivery", "off"])
failed = json.loads(output.getvalue())["interaction_contract"]["agent_channel"]
assert code == 0 and failed["delivery_allowed"] is False
assert failed["work_context"]["complete"] is False
assert any(row.get("source") == "goal_acceptance" for row in failed["required_reads"])
assert planner_sources
for source in planner_sources:
assert set(source) == {"selected_todo", "task_orchestration_contract", "effective_action", "interaction_contract"}
assert set(source["interaction_contract"]["cli_channel"]) <= {"selection_required"}
assert set(source["task_orchestration_contract"]) <= {"schema_version", "mode", "primary_todo_id"}
recovered = cli("quota", "should-run", "--goal-id", goal, "--agent-id", "agent-a", )
assert recovered["interaction_contract"]["agent_channel"]["work_context"]["complete"] is True

Expand Down
Loading