Skip to content

Reduce temporary Inbox receipt buffer allocations #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Nov 7, 2026
Merged

Reduce temporary Inbox receipt buffer allocations #8244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions loopx/control_plane/collaboration/inbox_read.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,21 @@ function readRecord(path: string): JsonObject {
try {
const stat = fstatSync(fd);
if (!stat.isFile()) fail("invalid manager context record");
if (stat.size > 128_000) fail("manager context record too large");
const buffer = Buffer.alloc(128_001);
const limit = 128_000;
if (stat.size > limit) fail("manager context record too large");
// Most receipts are small. Read one byte past the observed size so an
// in-place append still gets the same bounded read through EOF.
let buffer = Buffer.alloc(stat.size + 1);
let size = 0, count: number;
while (size < buffer.length && (count = readSync(fd, buffer, size, buffer.length - size, null)) > 0) size += count;
if (size > 128_000) fail("manager context record too large");
while ((count = readSync(fd, buffer, size, buffer.length - size, null)) > 0) {
size += count;
if (size > limit) fail("manager context record too large");
if (size === buffer.length) {
const expanded = Buffer.alloc(limit + 1);
buffer.copy(expanded);
buffer = expanded;
}
}
const bytes = buffer.subarray(0, size);
let parsed: unknown;
try {
Expand Down
9 changes: 9 additions & 0 deletions tests/control_plane_ts/inbox_read_transaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,15 @@ for (const bytes of [Buffer.from("\ufeff{}"), Buffer.from([0xff]), Buffer.alloc(
});
}

test("a valid record at the byte limit retains its complete content", async t => {
const f = fixture(t), request = f.publish(1);
const path = join(f.folder, request.request_id + ".json");
const original = readFileSync(path);
writeFileSync(path, Buffer.concat([original, Buffer.alloc(128_000 - original.length, 32)]));
const result = (await f.call("pending", {request_id: request.request_id})).result as JsonObject;
assert.equal((result.items as JsonObject[])[0].message, request.message);
});

test("malformed receipts retain the request and recovery advice", async t => {
const f = fixture(t), request = f.publish(1);
mkdirSync(join(f.base, "decisions"));
Expand Down
Loading