Skip to content

test(chat): lock strict native thread identities in exhausted-answer recovery #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Nov 6, 2026
Merged

test(chat): lock strict native thread identities in exhausted-answer recovery #8158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/control_plane_ts/conversation_binding.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,25 @@ test("exhausted business quota permits one read-only answer, never a fresh busin
"a later restricted answer must not strand the other exact historical failures");
assert.notEqual(planBoundConversationRequest({...migrated, current_session: {...migrated.current_session,
upstream_context_history: [{thread_id: "native", manager_context_version: 22, agent_id: "antigravity"}]}}).recovery_eligible, true);
const history = {...session, upstream_context_history: [{thread_id: "123", manager_context_version: 22}]};
for (const thread_id of [123, null, false, {}, [], "foreign"]) {
const prior = planBoundConversationRequest({...packet, current_session: history,
request: {...packet.request, context_recovery: {...previous, native_observation: {thread_id}}}});
assert.deepEqual(prior.native_thread_ids, ["native", "123"],
"an untrusted prior identity cannot reorder validated string identities");
const proof = planBoundConversationRequest({...packet, current_session: {...session, upstream_thread_id: "123"},
context_recovery: {...packet.context_recovery,
native_observation: {...packet.context_recovery.native_observation, thread_id}}});
assert.equal(proof.recovery_candidate, true);
assert.equal(proof.recovery_eligible, false, "a proof must match without identity coercion");
}
assert.deepEqual(planBoundConversationRequest({...packet, current_session: history,
request: {...packet.request, context_recovery: {...previous,
native_observation: {thread_id: "123"}}}}).native_thread_ids, ["123", "native"]);
assert.equal(planBoundConversationRequest({...packet,
current_session: {...session, upstream_thread_id: "123"},
context_recovery: {...packet.context_recovery, native_observation: {...proof, thread_id: "123"}}}).recovery_eligible, true,
"numeric-looking string identities remain valid");
for (const change of [{source_verified: false}, {stop_observed: true}, {steering_observed: true},
{attachments_present: true}, {queued_input_present: true}, {metadata_capacity: null},
{executor_configuration: {...configuration, configuration_revision: "changed"}},
Expand Down
Loading