Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
Move the peer-directory decision owner into one TypeScript projection while retaining the public
agent-directorycommand and Python compatibility signature.agent.directory.projectrequest owns membership, work fields, route publication caps, counts, cursor, limitations and page-local rollup, and seals the projection envelope in the same TypeScript process.Intended base:
mainatfaab5f5c291c5359216a0f944fe63fcfbaacdedc, rechecked before publication.Author Declaration
Written by: model_agent, OpenAI Codex.
Implemented against
Specification:
docs/architecture/rfcs/typescript-control-plane-migration-v0.mdanddocs/reference/protocols/peer-agent-directory-and-observation-v0.mdat the base revision, with the bounded migration and source-evidence contract documented in this change's bilingual ledger.loopx/control_plane/agents/directory.ts; Python fact adapterScope And Continuation
This is a bounded, reversible projection migration. It does not change claims, leases, persistence or provider defaults, create a presence provider, or grant execution authority. Management state and route interpretation retain their existing owners.
The Python adapter can be retired when production callers and fact providers can call the native owner directly. Broader TypeScript migration and release qualification remain open. The measured transport/output cost and remaining CI/DCO gates are disclosed below. This draft is not merge-ready.
Validation
Tested candidate:
9d91c5bc178a0acddbbab3276b404b9d0ceada3f.Initial published code commit:
a81fc32ee62537a5861693248671f069366f810e, with identical complete Git tree330c5cd638c0adc2d615cea794cee90e41ce7436to the tested candidate.Current head:
983caa3230d097ff54623b511e525835769688cf, which adds only the two bilingual qualification-ledger updates. Its complete Git tree4b32cc1cfa8dbceb80a2615b61af3a3845a46472matches local documentation candidateee778490c42866e74a1694add7886a0b77131e3b. Product code is unchanged.Run state: finished for the local checks below; remote CI remains pending.
Input classes: synthetic.
Matched whole-CLI performance
120 paired CLI runs passed in a fresh isolated full rerun. Values below are baseline → candidate, in milliseconds.
Runtime requests increased from 5 to 6 and stdout from 9,330 to 11,384 bytes. Cold p95 increased on both backends; these observations do not establish a speedup. The earlier attempt had a stale-runtime transport failure; that failed attempt is preserved, and the fresh isolated full rerun completed without failures.
Remote CI has not yet qualified this published revision. The above targeted and suite results do not establish whole-Goal outcomes, performance improvement or release readiness.
Remote CI findings on current head
CI is still running. The real-server PostgreSQL authority job, kernel static checks, kernel contracts, both stage2c e2e jobs and both build jobs have passed. Remaining queued/running jobs are not counted as passes.
test_doctor_fix_preserves_installation_ownervariants fail withKeyError: 'installer'. The same failures occur on main ancestor817dd246in baseline job; the doctor/test files are unchanged from that ancestor through the implementation base and candidate.zcode-persistent-browser-smoke.mjs:59times out on a disabled Start button afterauthority_or_quota_unavailable. The same failure occurs in PR #8110 job. Its merge is an ancestor of the implementation base, and the ZCode runtime, smoke and fixture files are unchanged through that base and candidate.These bounded source/history comparisons support pre-existing failure attribution; they do not waive required CI or establish a full baseline replay.
Frontend / Visual Evidence
UI impact: none. No graphical layout changes; screenshots and viewports are not applicable. The CLI gains the documented envelope and necessary source-warning presentation.
Type of Change
LoopX Area
Technical Direction
Bounded T3 projection ownership within the TypeScript control-plane migration. This does not close T4.
Shared-authority RFC fixture impact
No authority-store schema, dual-write, persisted migration or provider-default change. Fixture coverage includes full-registry versus page membership and envelope source evidence. No PostgreSQL or three-arm promotion qualification is claimed.
Boundary Checklist