Skip to content

test: restore policy reads in wait and monitor closeout journeys #8058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Nov 4, 2026
Merged

test: restore policy reads in wait and monitor closeout journeys #8058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/control_plane/test_dated_vision_wait_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import pytest
from canonical_authority_fixture import read_fixture_todos, initialize_canonical_source_fixture
from tests.control_plane.codex_checkpoint_fixture import read_cli_policy_payload

from loopx.control_plane.effect_runtime import restart_effect_runtime

Expand Down Expand Up @@ -79,7 +80,7 @@ def cli(registry: Path, runtime: Path, *args: str) -> tuple[int, dict]:
cwd=REPO, env={**os.environ, "PYTHONPATH": str(REPO), "LOOPX_USAGE_PING": "0"},
capture_output=True, text=True, check=False, timeout=90,
)
return result.returncode, json.loads(result.stdout)
return result.returncode, read_cli_policy_payload(result.stdout, returncode=result.returncode)


@pytest.mark.parametrize("provider", ["file", "sqlite"])
Expand Down
5 changes: 3 additions & 2 deletions tests/control_plane/test_monitor_unavailable_closeout_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import pytest

from canonical_authority_fixture import initialize_canonical_authority, isolate_sqlite_runtime, read_fixture_todos
from tests.control_plane.codex_checkpoint_fixture import read_cli_policy_payload
from loopx.cli import main as cli_main
from loopx.control_plane.coordination.runtime_shadow import build_todo_runtime_shadow_projection
from test_quota_settlement_cli import (
Expand Down Expand Up @@ -55,7 +56,7 @@ def cli(*args: str) -> tuple[int, dict]:
context.chdir(project)
rc = cli_main(["--registry", str(registry), "--runtime-root", str(runtime),
"--format", "json", *args])
return rc, json.loads(capsys.readouterr().out)
return rc, read_cli_policy_payload(capsys.readouterr().out, returncode=rc)

if provider == "markdown":
before = state.read_bytes()
Expand Down Expand Up @@ -327,7 +328,7 @@ def cli(*args: str) -> tuple[int, dict]:
context.chdir(project)
rc = cli_main(["--registry", str(registry), "--runtime-root", str(runtime),
"--format", "json", *args])
return rc, json.loads(capsys.readouterr().out)
return rc, read_cli_policy_payload(capsys.readouterr().out, returncode=rc)

binding = ("--agent-id", AGENT_ID, "--todo-id", TODO_ID, "--turn-instance-id", "invalid-monitor")
rc, guard = cli("quota", "should-run", "--goal-id", GOAL_ID, "--codex-app", *binding)
Expand Down
Loading