Skip to content

fix(smoke): release original analysis reads after loading #8037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 2 commits into from
Nov 4, 2026
Merged

fix(smoke): release original analysis reads after loading #8037

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f924ed4
fix(smoke): release original analysis reads after loading
loopx-agent Nov 4, 2026
0d5edce
Merge branch 'main' into codex/research-loading-fixture-20261104
huangruiteng Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/personal-workspace-browser/research-route-reading.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ export const researchRouteReadingScenario = {
if (collectCoverage) await page.coverage.startJSCoverage({resetOnNavigation: false});
const url = new URL("/chat/?goalId=synthetic-route-reading&view=research&statusUrl=%2Fstatus.json", owner.base).href;
let state = "deep", analysisWrites = 0, releaseLoading;
let loadingRead = Promise.resolve();
await page.route("**/api/chat/research-analysis?*", async route => {
if (route.request().method() !== "GET") {analysisWrites++; return route.abort();}
if (state === "loading") await new Promise(resolve => {releaseLoading = resolve;});
if (state === "loading") await loadingRead;
const language = new URL(route.request().url()).searchParams.get("output_language");
const snapshot = analysisReadback();
snapshot.pack.config = {...snapshot.pack.config, output_language: language};
Expand All @@ -98,6 +99,8 @@ export const researchRouteReadingScenario = {
await page.goto(url, {waitUntil: "domcontentloaded"});
await page.evaluate(locale => localStorage.setItem("loopx-pw-locale", locale), language);
for (state of ["loading", "deep", "view", "reuse", "continue", "running", "unavailable"]) {
// One release covers this read and its subsequent original fallback.
if (state === "loading") loadingRead = new Promise(resolve => {releaseLoading = resolve;});
await page.reload({waitUntil: "domcontentloaded"});
await caption.first().waitFor();
assert.equal(await page.locator("html").getAttribute("lang"), language);
Expand Down
Loading