Skip to content

fix(workspace): restore worker status and narrow research layout - #7995

Merged
huangruiteng merged 1 commit into
mainfrom
codex/fix-worker-status-layout-20261103
Nov 3, 2026
Merged

huangruiteng merged 1 commit into
mainfrom
codex/fix-worker-status-layout-20261103

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Restore the existing worker-status layout and narrow research-card spacing lost during the S5/S11 styling update. The worker title and explanation regain a flex row with an 8px gap; mobile research actions lose the extra 30px indentation and recover their vertical spacing. This keeps the current card hierarchy and collapsed details.

On main 44337e3cb5, the existing workspace contract fails on the missing worker-status flex rule. Restoring that rule reveals the next existing failure on narrow research-action spacing. Both original assertions now pass without test changes. The build and three browser jobs on #7989 failed at the same first assertion and checked out the same pinned merge 32f3e569; their source/artifact revisions were aligned.

Validation:

  • Existing personal-workspace-contract.test.mjs: passes, including its 4 receipt/readback tests.
  • Full dashboard build: TypeScript, dashboard Vite, and packaged Chat build/verification pass. The existing chunk-size advisory remains.
  • CSS custom-property classifier and 36-stylesheet scan: pass. RFC bilingual staged diff check passes; no RFC changes.
  • Ego Lite with the real disposable worker/CLI File authority: paused and unknown observations, Chinese and English, 1512px desktop and 390px narrow views; explanation opens and closes with Escape, original obligation and unbound Turn remain readable, and task navigation works. Checked regions have no horizontal overflow; research empty-state actions are keyboard reachable.
  • Both fixtures preserve the original Goal fields and byte-identical history; their controlled startup dispatch count stays at one. Browser inspection causes no additional dispatch. Both fixture processes exit 0 on normal cleanup.

Visual evidence — before 44337e3cb5, after fb1d6a975. These are actual packaged Chat first viewports on synthetic disposable backend data. Current worker state is primary; its explanation and diagnostic fields remain on demand. The expanded unknown-state example preserves the uncertainty about costs and the original request. This bounded fixture review does not qualify a populated production board, the installed app, or native MacWebView.

1512×982 Before After
Goal overview Before desktop After desktop
390×844 Before After
Goal overview Before narrow overview After narrow overview
Research empty state Before narrow research After narrow research

Expanded unknown worker observation in English at 390px

Only the two existing CSS owners change. No runtime, authority, defaults, protocol, model dispatch, or installed delivery changes. Larger layout work is outside this regression fix. Independent CI/review and merge readiness remain separate; this proposal is submitted for review and is not merged.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

本次 exact-head review:fb1d6a975c51ea0b1b1cb9d1dcb1ad2edd483051,base 44337e3cb5cbe3e1621550e1fe741853ba5b5a45。未发现阻断性问题;结论 APPROVE。

Reviewer: model_agent; model=gpt-6.1-sol; provider=OpenAI; reasoning_effort=max; runtime_reported; observation_id=2fbb2b553810b7774f24dd85bb445e632b46720d0b05ea06e9b5bbfe9e9d7d3e

动机

在 Goal 概览核实执行状态、或在手机宽度查看研究记录的工作区用户。查看已暂停的执行器或窄屏研究空态时,状态与帮助图标失去并排布局,按钮还保留多余的行首缩进。 帮助图标与状态的联系变弱,窄屏按钮又带着旧缩进;这使用户核实执行状态和找到研究入口时多一次视线跳转。状态与帮助图标恢复 flex 对齐和 8px 间距;390px 研究空态按钮从 30px 行首偏移改为 0,并保留 8px 顶部间距。 此 PR 只恢复两个已有 CSS 约束;不改变状态含义、任务调度、帮助文案、权限或模型调用。

这里的可验证增量是恢复已有展示约束,不是增加一种执行器功能。未验证安装态 macOS WebView、生产大规模 Goal 数据和真实模型结果;这些不是本次两处样式恢复的交付声明。 不把构建通过、字段存在或一次 worker 夹具运行解释为 Goal 达成、费用完整或长期效果提升。既有状态文案仍区分 paused 与 unknown,完整成本仍明确未知。

改动思路

布局约束已有明确 caller 和未改动的回归断言;直接恢复原 selector 最小且可逆,不需要新组件、状态字段或配置入口。 保留既有 JSX、ContextHelp、状态读取和响应式规则,仅在原有 stylesheet owner 恢复缺失属性。 执行器观察仍由 WorkerReadback 渲染,帮助沿用 ContextHelp,原义务、Turn 和时间留在默认折叠的详情中;研究记录的读取失败/空态按钮复用同一窄屏规则。CSS 没有接管结果判断、重试或任务导航,因此也没有新增状态或权限来源。

独立规范为 docs/development/design.md,spec_revision 44337e3cb5cbe3e1621550e1fe741853ba5b5a45,先于实现读取。逐项检查规范原有标题:Earn The User's Attention(状态优先、帮助按需);Populated Page Review(长内容、重复 mixed 状态、展开和下半页);Responsive Behavior(窄屏可读和动作可达)。这些要求由下述 packaged 页面观察支撑;压力夹具的边界单独说明,没有把本 PR 改写出的断言当作原规范。

具体改动

.goal-overview-worker-status;<=640px research empty/read-error button。第一处补回 display:flex、align-items:center、gap:8px;第二处在原 max-width:640px 中把按钮 margin-inline-start:30px 改成 0,增加 margin-top:8px。全 PR 只有两个 CSS 文件 +6/-1;既有 JSX、文案、默认折叠、已有 flex-wrap 和所有行为 owner 未变。

同一未改动 workspace contract:base 在缺失 flex 的断言失败,head 通过并含4个 receipt/readback 测试;两边 Dashboard TypeScript/Vite/packaged Chat build 与 CSS classifier 通过,head standard premerge 通过。Ego Lite 独立检查 packaged Chat + disposable real File worker/CLI authority 的 paused/unknown、1512×982 与390×844、zh/en、帮助/Escape、展开与任务导航。 实测 base 状态容器为 block/gap normal,head 为 flex/gap8px;研究空态按钮 base 为 inline30px/top0px,head 为0/8px。默认详情关闭,展开后完整原义务及未绑定 Turn 提示可读;帮助可见未知费用说明,Escape 关闭后焦点回到触发按钮;现有任务按钮实际导航到 Tasks。三组隔离 authority 在后续视觉压力与导航前后 registry/history 字节摘要相同,各自 dispatch 仍为1;TaskSpace 已关闭,三个 fixture 正常退出0。

对主干的风险

未观察到调度、权限、状态或 provider 语义变化。最强反例是“正则测试通过但长状态、帮助或展开证据在390px不可读”,因此补了实际整页和下半页视觉检查,而没有仅凭 no-overflow 宣布合格。长英文 unknown 状态会换行,帮助仍可到达;展开原工作字段采用窄屏单列,长义务也能换行,底部任务动作可见。

两边锁定依赖的 Dashboard/packaged Chat build 都有现存大 chunk advisory;依赖准备有 fsevents allowScripts notice,均未被改写为无警告。head standard premerge 的直接检查与两个 catalog canary 通过,manual holds=0;它不等于合并授权。CI 按当前 wait_for_ci=false 未查询、轮询或等待,作者已提供的历史 CI 描述仅作诊断,不声称远端已绿。

我的整体评价

桌面首屏仍以状态为主,帮助按需展开;390px 长英文状态自然换行,展开的原工作记录与底部任务入口均可到达。 四行中英混合长内容来自明确标注的 DOM 布局压力夹具;未作为真实多 Agent 运行、生产大规模数据或安装态验收。 视觉证据来自本地 exact-head packaged Chat 与真实隔离 worker/File authority;额外 DOM 行只检验 CSS 长内容承载,不代表新增 Agent 的真实运行。该受限结论足以支持已有两处样式约束的恢复;未要求重做整个工作区,也不外推为安装态或完整生产容量资格。

架构与规模判断为 retain/proportionate:继续使用原 stylesheet owner,六行恢复已被原有契约和实际页面共同验证;没有值得为本次变更新建的抽象。保留既有 JSX、ContextHelp、状态读取和响应式规则,仅在原有 stylesheet owner 恢复缺失属性。 后续 approval closeout 与 merge readiness 要读回相同 head,review 结论不授予 merge/install 权限。

English verdict: APPROVE. The existing layout contract fails at the immutable base and passes at this head; independent packaged desktop/narrow visual inspection confirms the bounded CSS repair. Remote CI was not consulted. Installed WebView, production-scale data and live-model outcomes remain unverified; no merge was performed.

@huangruiteng
huangruiteng merged commit 472a397 into main Nov 3, 2026
35 checks passed
@huangruiteng
huangruiteng deleted the codex/fix-worker-status-layout-20261103 branch November 3, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants