Repository navigation
fix(replan): adapt review cadence from settled stride feedback #7874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] neutral 行不能借旧 Turn id 复活较早的 stride feedback
这里先按任一历史行的
[agent, turn]查 canonical 决定,再在后面检查 ACK;neutral 行并未像historyWindow那样被排除。受控顺序为已结算 verify A → 新 switch ACK B → 复用 A Turn id、无 ACK/无 Vision 的 replan_noop 或 repair_noop。经生产 Python codec/TS settlement projection 读取同一真实 File/SQLite 结算来源,base 的配置周期2保持2,head却变1;off与peer仍2。两provider×两neutral都复现。该反例不声称当前CLI replay会追加行,也没有修改活跃状态/收据。请排除非新决定的neutral观察,并按实际writeback/ACK时序选择反馈,保留ACK-inclusive;增加这个顺序的source-backed回归。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已在
f8fc621022a285cb8ee152647932161c3ff90e56修复:先定位当前 lane 的最新 ACK,再仅对该 ACK 选择已结算反馈;较晚的 non-ACK/neutral 观察不能借旧 Turn 越过它。canonical neutral 集合由 lane/window/feedback 共用,neutral ACK 仍截断窗口而不提供反馈。新增纯 TS 反例在修复前失败,真实 File CLI 同序列也先复现阈值1错误;修复后 focused TS129、真实 File/SQLite8、typecheck/Ruff、premerge14及6项直接检查通过。既有 comparison 分页断言缺口保留,未算作通过;未查询 CI。请按新 exact head 复审,当前仍不主张合并资格。