fix: allow mobile release scripts to sync Capacitor - #52
Open
ehussong wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read the mobile app version from
src/main/frontend/version.cljsinstead of the generatedstatic/package.json.The Android and iOS release scripts move
static/intopublic/before Capacitor loadscapacitor.config.ts. Reading the canonical source version keeps the configuration available throughout that release sequence and matches the version source updated by the release workflows.Verification
Tested with
static/package.jsonabsent, matching the reported failure state:npx cap sync androidwithENOENT: no such file or directory, open 'static/package.json'.npx cap sync androidsuccessfully.npx cap sync iosparses the configuration and copies assets successfully; native dependency installation could not complete because this Mac does not have CocoaPods or full Xcode installed.capacitor.config.tspasses TypeScript compilation.git diff --check.Fixes #15