fix(publishing): exclude desktop restart calls from publishing builds - #48
Open
soizo wants to merge 1 commit into
Open
fix(publishing): exclude desktop restart calls from publishing builds#48soizo wants to merge 1 commit into
soizo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this while auditing the optimized publishing bundle from the current
version/filebranch on macOS (Apple Silicon).The publishing bundle contains calls compiled as
$logseq$$.api.$relaunch$(), but that build does not include the desktoplogseq.apiimplementation. The desktop bundle includes and exportslogseq.api.relaunchas expected.Most of the affected controls are already hidden by runtime Electron checks, so I did not reproduce this through the normal publishing UI. However,
/settingsis still part of the publishing build, and the invalid API references remain in the generated artifact.This change adds publishing guards to the five restart actions and their render sites. It keeps the settings route and the existing desktop behavior unchanged.
I tested optimized publishing and desktop builds with Node 18. In the generated artifacts, the publishing bundle no longer contains
.$relaunch$()orlogseq.apireferences, while the desktop bundle still exports and callslogseq.api.relaunch.