fix(electron): make New Window work on macOS with an open graph - #47
Open
soizo wants to merge 1 commit into
Open
fix(electron): make New Window work on macOS with an open graph#47soizo wants to merge 1 commit into
soizo wants to merge 1 commit into
Conversation
soizo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reproduced this on macOS (Apple Silicon) with Logseq OG 1.0.0 build 92, based on Electron 41.7.1. File → New Window and Command+N did nothing when a graph was open, while a clean profile worked.
In the optimized build,
get-active-window-graph-pathcompiles the ElectronisFocused()call as$isFocused$(). The resulting exception happens before graph persistence or window creation.This change uses the existing
BrowserWindow.getFocusedWindow()helper instead and keeps the current persist-before-open flow.I tested it with an optimized Electron build and an isolated application profile. In that test the window count changed from 1 to 2, and the new window loaded and received focus.