Fix SFP led for 2.5gbit for MACHINE_SWGT024_V2_0#249
Merged
Conversation
While testing logicog#246, I noticd that SFP did not light-up while forcing 2.5gbit link. This is because RJ45 and SFP share the same LED-settings. But RJ45 has two leds-settings. Solution is to add settings for SFP for both managed and unmanaged variant.
feelfree69
approved these changes
May 30, 2026
feelfree69
left a comment
feelfree69
left a comment
Collaborator
There was a problem hiding this comment.
Can't test it on my hardware, but code is looking good.
Owner
|
Looks good to me, too! Nice work with the LED-sets! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing #246, I noticd that SFP did not light-up while forcing 2.5gbit link. This is because RJ45 and SFP share the same LED-settings. But RJ45 has two leds-settings.
Solution is to add settings for SFP for both managed and unmanaged variant.