Add Steamemo IG204 V1 support#209
Conversation
|
Sorry for looking only now into this, I had planned to do this already yesterday, and then the German DNS broke down... This is great stuff, we have been waiting for a configuration generator from a dump for quite some time! |
|
Could you please check the code? This PR is only for Steamemo IG204 V1 device support. I haven't made the PR request for tools ( as it is not ready for prime time). I think the commit comments you saw was from a different branch. Thanks, |
|
Code looks very good! Could you add some documentation for the Steamemo device, such as an .md file in doc/devices, plus pictures of the PCB in doc/devices/photos/ These pictures can help a lot when people need to decide whether the device they have is actually already supported, but e.g. under a different brand name. Have a look at the examples. You can take the photos with your smartphone, the image quality is more than enough. What would be really great would be if you could clean up this PR a bit: you can use |
I know @logicog is an git expert.... but with such a small PR, I would simply create a new branch from main, copy the changed 2 files in there, commit and then add the docu with an extra commit Then you're done with that:
|
|
Oops, I think you added several of the latest merges into this PR. There are 2 ways to fix this:
|
|
Fixed the PR based upon your commendation option 1. Please check. |
|
Do you have a description of the device in a .md file? And everyone loves pictures of the PCB, because that way it is easier to check whether 2 devices are actually identical . |
|
md and jpg files have been added. |
Add support for "Steamemo IG204 V1" unmanaged switch.