Skip to content

Webif#202

Closed
feelfree69 wants to merge 2 commits into
logicog:mainfrom
feelfree69:webif
Closed

Webif#202
feelfree69 wants to merge 2 commits into
logicog:mainfrom
feelfree69:webif

Conversation

@feelfree69
Copy link
Copy Markdown
Collaborator

@feelfree69 feelfree69 commented Apr 18, 2026

As I have no clue about html and Javascript, that's why I thought I let Copilot do some work.
It's not meant for immediate merge, but at least I want to share the results.
The improved User-Experience when uploading a new firmware image has some potential. With my Firefox on Windows the Upload and Redirect to Login-Page works flawlessly.
Well, the colors might not be the first choice....

grafik grafik

What I'm not sure about: I have the feeling that with the "modern look", also the Performance has increased, maybe due to better caching strategies in the browser? Most pages load almost immediately now, where with the old design there were frequent delayed loadings especially at the port-icons at the top of the page.

@logicog
Copy link
Copy Markdown
Owner

logicog commented Apr 18, 2026

Thanks for sharing this, the upload can definitely profit from a better UI and the redirect is currently indeed broken! A fix for Chrome would however need changes in the C-backend handling the POST request, at least that is what the http-experts say.

What I'm not sure about: I have the feeling that with the "modern look", also the Performance has increased, maybe due to better caching strategies in the browser? Most pages load almost immediately now, where with the old design there were frequent delayed loadings especially at the port-icons at the top of the page.

I do not see anything touching the ports or related to concurrency in the javascript embedded in the html pages of the code, but if you are comparing the situation to about 1 month ago, then there was a considerable improvement of the loading of the pages with PR #151 .
If you want to give your hunch some numbers to back it up, have a look at timing diagrams in the debug console of Firefox, like the one posted in that PR.

For proceeding with this request: maybe try to disentangle the design part, i.e. the stuff in the stylesheets, from the functional part like the redirect and the information bar so that we can get the functionality in without necessarily a change of the entire design. Ideally, we anyway want to have different "skins" for the UI so that users can have a UI they like design-wise as design is always rather a personal thing.

@feelfree69
Copy link
Copy Markdown
Collaborator Author

maybe try to disentangle the design part, i.e. the stuff in the stylesheets, from the functional part like the redirect and the information bar

Both parts are already separated by the 2 commits.

@vDorst
Copy link
Copy Markdown
Collaborator

vDorst commented Apr 18, 2026

Looks nice.
I was worried that it may try to pull an external library from the web. But lucky it is
not.

I think we can improve the speed a bit by removing some __gptrget call in the IP-stack.
See also #169 (comment)
__gptrget call is used when the compiler doesn't know which memory is used for the variable.
If we can improve that, it saves overhead, memory and speed.

@logicog
Copy link
Copy Markdown
Owner

logicog commented Apr 18, 2026

I was not aware that uIP is still using gptr, that needs to go. Still, the __gptrget stuff is probably a bit off-topic for this PR. Can we get merely the UI-part in this PR without the change in style? Also, so far all the javascript was always in the .js files, now it is mixed into the html files. I think it would be great to keep that separation, for example if we want the UI to be translated into other languages, we would only need to have different html files for a different language while the .js stay the same as they are just functionality. (OK, some of the .js have text inside, but that could be taken from the .html files, too, instead of coding it into the .js.)

@feelfree69
Copy link
Copy Markdown
Collaborator Author

as written before, i only wanted to share the results of my 1hr playing with copilot. i did not take a single look at the code, and i have no motivation to do so... sorry

@feelfree69
Copy link
Copy Markdown
Collaborator Author

Will close the PR as it was never intended to merge, and as there is already a far more better UI in work (#220).

@feelfree69 feelfree69 closed this May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants