Conversation
…existing installs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces robust handling for the
TALOS_ENCRYPTION_KEY, ensuring that Talos never silently regenerates the encryption key for existing installations—a critical change for the security and recoverability of encrypted service credentials. Now, Talos will only auto-generate the encryption key on first install, and will fail fast if the key is missing on an existing install, preventing accidental data loss. The installer and documentation have been updated to support explicit key regeneration, with clear user warnings and recovery instructions.Encryption key handling and startup logic:
TALOS_ENCRYPTION_KEYon first install. On existing installs, startup fails if the key is missing, instead of generating a new one that would break access to encrypted credentials (cmd/talos/main.go, [1] [2] [3] [4].cmd/talos/main_test.go, cmd/talos/main_test.goR52-R117).Installer improvements:
--regenerate-encryption-keyflag toinstall.sh, allowing explicit, user-confirmed key rotation with clear warnings about destructive effects on existing encrypted credentials (scripts/install.sh, [1] [2] [3] [4] [5].Documentation and user guidance:
README.md, [1] [2] [3];docs/features/managed-services.md, [4];docs/guide/backup.md, [5];docs/guide/configuration.md, [6] [7];docs/guide/installation.md, [8];docs/guide/upgrading.md, [9] [10] [11].These changes make encryption key handling explicit, safe, and user-driven, preventing accidental data loss and improving upgrade reliability.…existing installs