Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the test code for the deploy event streaming handler to improve thread safety and reliability. The main change is the introduction of a custom
safeRecorderto replace the standardhttptest.NewRecorder()in tests that involve concurrent writes, ensuring thread-safe access to the response body.Test infrastructure improvements:
safeRecordertype to replacehttptest.NewRecorder()in tests, preventing race conditions when accessing the response body during concurrent event streaming. (internal/server/handlers/deploy_test.go)newSafeRecorder()instead ofhttptest.NewRecorder(). (internal/server/handlers/deploy_test.go) [1] [2] [3]rec.Body.String()with the new thread-safe methodrec.BodyString(). (internal/server/handlers/deploy_test.go) [1] [2] [3]Dependency updates:
"bytes"import to support the new recorder implementation. (internal/server/handlers/deploy_test.go)…ming tests