Conversation
… and event loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the deploy history UI and optimizes the deploy execution process, especially for Talos builds. The main changes include skipping image pulls for locally built images, refining how deploy events are loaded and displayed, and updating the HTML structure to better handle deploy history updates and empty states.
Backend improvements:
Engine.executemethod now takes askipPullparameter to optionally skip pulling the Docker image if it was just built locally (e.g., by Talos), improving deploy efficiency. [1] [2] [3]Frontend/UI improvements:
toggleDeployEventsJavaScript function, and the corresponding HTML indeploy_row.htmlis updated for this logic. [1] [2] [3]#deploy-history-anchor) for HTMX swaps, and empty state handling is improved to remove the "No deploys yet" message after the first deploy. [1] [2] [3] [4]These changes make the deploy process more efficient for Talos builds and provide a more responsive and user-friendly deploy history UI.… and event loading