Repository navigation
Calendar: one main heading on the Discover calendar - #93
Open
TheMightyTRex wants to merge 1 commit into
Open
TheMightyTRex wants to merge 1 commit into
TheMightyTRex wants to merge 1 commit into
Conversation
Discover, Calendar had two h1 headings: Discover's visually hidden page heading and the calendar's own "Calendar" heading. Screen readers announced both as main headings, where a page should have one. The calendar's heading is now an h2 under the Discover heading, as in the other Discover views, so it also takes their heading style. Adds a mocked UI test that the calendar view has a single h1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Discover, Calendar has two
h1headings: Discover's visually hidden page heading and the calendar's own "Calendar" heading. Screen readers announce both as main headings. A page should have one main heading, with its sections below it (WCAG 1.3.1 and 2.4.6).Change
The calendar's heading in
ReleaseCalendar.tsxis now anh2under the Discover heading, as in the other Discover views. It also picks up the same heading style as those views.Testing
tests/ui/release-calendar-heading.spec.ts: the calendar view has exactly oneh1("Discover") and shows "Calendar" as anh2. The test fails against the current code and passes with the change.npm run typecheck,npm run buildandprettier --check src testspass.playwright.ui.config.ts, Chromium): 148 of 148 pass.🤖 Generated with Claude Code