Skip to content

Calendar: one main heading on the Discover calendar - #93

Open
TheMightyTRex wants to merge 1 commit into
logabell:mainfrom
TheMightyTRex:contrib/calendar-one-heading
Open

TheMightyTRex wants to merge 1 commit into
logabell:mainfrom
TheMightyTRex:contrib/calendar-one-heading

Conversation

@TheMightyTRex

Copy link
Copy Markdown

Problem

Discover, Calendar has two h1 headings: Discover's visually hidden page heading and the calendar's own "Calendar" heading. Screen readers announce both as main headings. A page should have one main heading, with its sections below it (WCAG 1.3.1 and 2.4.6).

Change

The calendar's heading in ReleaseCalendar.tsx is now an h2 under the Discover heading, as in the other Discover views. It also picks up the same heading style as those views.

Testing

  • New mocked UI test tests/ui/release-calendar-heading.spec.ts: the calendar view has exactly one h1 ("Discover") and shows "Calendar" as an h2. The test fails against the current code and passes with the change.
  • npm run typecheck, npm run build and prettier --check src tests pass.
  • Full mocked UI suite (playwright.ui.config.ts, Chromium): 148 of 148 pass.

🤖 Generated with Claude Code

Discover, Calendar had two h1 headings: Discover's visually hidden
page heading and the calendar's own "Calendar" heading. Screen readers
announced both as main headings, where a page should have one.

The calendar's heading is now an h2 under the Discover heading, as in
the other Discover views, so it also takes their heading style.

Adds a mocked UI test that the calendar view has a single h1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant