Repository navigation
Release notes window: numbered lists, wrapped items, one title - #92
Open
TheMightyTRex wants to merge 1 commit into
Open
TheMightyTRex wants to merge 1 commit into
TheMightyTRex wants to merge 1 commit into
Conversation
The release notes window opened from the version in the sidebar showed Dewarr's notes badly. The release's name appeared twice, because the notes themselves start with "# Dewarr vX.Y.Z". Numbered lists lost their numbers and became plain paragraphs, and a list item that continued on an indented line was split off from its item. - The notes parser recognises numbered lists and keeps an indented continuation line with the item above it. Nested items are kept in the same list. - A first heading that matches the release's name is not shown again. - Headings in the notes are bold and sized by level, and numbered lists show their numbers. Adds unit tests for the parser and a mocked UI test of the window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release notes window, opened from the version in the sidebar, does not show Dewarr's own release notes well:
-or*, so a numbered list is shown as a run of plain text.Change
releaseNotes.ts: the parser recognises numbered list items (1.), keeps an indented continuation line with the item above it, and keeps nested items in the same list. List blocks now say whether they are ordered.ApplicationRelease.tsx: ordered lists render as<ol>. When the first block of the notes is a heading that matches the release's name, it is not shown again.styles.css: headings in the notes are bold and sized by level, numbered lists show their numbers, and list items have a little more space between them.Testing
releaseNotes.test.tsfor wrapped items, nested items and numbered lists (3 of 3 pass).tests/ui/release-notes-layout.spec.ts: the release's name appears once, a wrapped item stays one item, a numbered list is shown with numbers, and section headings are bold.npm run typecheck,npm run buildandprettier --check src testspass.playwright.ui.config.ts, Chromium): 148 of 148 pass.🤖 Generated with Claude Code