Repository navigation
slskd: ask for an administrator API key when slskd hides its download folder - #89
Open
TheMightyTRex wants to merge 1 commit into
Open
TheMightyTRex wants to merge 1 commit into
TheMightyTRex wants to merge 1 commit into
Conversation
… folder slskd 0.26 answers GET /api/v0/options with 403 for read-write API keys, and Dewarr reads the download folder there, so the connection test failed with "use a read-write key on the main slskd process" even though the key was read-write. Check the key before the Soulseek session and explain the administrator role in the error, the settings help and the download clients guide. Reproduced against slskd 0.26.2 with read-write and administrator keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With slskd 0.26, testing the Soulseek connection with a read-write API key fails with "slskd refused this call; use a read-write key on the main slskd process", although the key already is read-write.
The test reads
GET /api/v0/optionsto find slskd's download folder. slskd 0.26 only shows its options to keys with the administrator role, so a read-write key gets403 Forbiddenthere./api/v0/applicationand/api/v0/application/versionwork with either key, which is why the API key itself looks fine with curl.Reported against both Dewarr and a fork in https://github.com/TheMightyTRex/storyarr/issues/1.
Change
SlskdClient.test()reads/optionsbefore checking the Soulseek session, so a key problem is reported before "Soulseek is not connected".docs/DOWNLOAD-CLIENTS.mdexplains the role, with aslskd.ymlexample./optionsproduces the administrator message.No database or API changes.
Testing
slskd/slskd:0.26.2container: a read-write key gets the new message; an administrator key passes the key check (and reports "Soulseek is not connected" only because the test instance was not logged in to Soulseek).tests/unit/test_slskd.pyandtests/integration/test_slskd_connection.py: 21 passed.🤖 Generated with Claude Code