Repository navigation
Fix two flaky tests (qBittorrent metadata timing, onboarding MAM row) - #87
Open
TheMightyTRex wants to merge 1 commit into
Open
TheMightyTRex wants to merge 1 commit into
TheMightyTRex wants to merge 1 commit into
Conversation
- The qBittorrent metadata test gave every case 0.2 seconds, including the cases that start the torrent probe subprocess, which can take longer on a busy machine. Only the pending case needs to time out, so the others now have 10 seconds. - The onboarding journey clicked the MAM row a second time when the first click had not rendered yet, which closed it again. It now waits for the form after each click. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests fail at random on a busy machine. Neither change affects the app.
tests/unit/test_qbittorrent_metadata.py: every case had 0.2 seconds, including the cases that start the torrent probe subprocess, which can take longer than that under load. Only thependingcase should time out, so the others now have 10 seconds. The assertions are unchanged.apps/web/tests/getting-started.spec.ts: the onboarding journey opens the MAM row, checks whether the form is visible, and clicks again if not. When the first click had not rendered yet, the second click closed the row, and the next step timed out. It now waits for the form after each click, and retries until it is open.Each passed repeatedly after the change: the unit test three times in a row, and the onboarding journey twice against a real server.
🤖 Generated with Claude Code