Repository navigation
Leave removed and confirmed-missing copies off My Library - #86
Open
TheMightyTRex wants to merge 1 commit into
Open
TheMightyTRex wants to merge 1 commit into
TheMightyTRex wants to merge 1 commit into
Conversation
…shelf My Library listed every book Dewarr had ever seen a file for. After a library reorganisation, files marked intentionally-removed or missing-confirmed showed up as unticked books under their old file names, next to the same books under their new names. Title-family grouping could also pull a removed copy back in when its title matched a book still in the library. The bookshelf (GET /api/library/books) now leaves out copies in CLOSED_STATES unless that state is asked for (?state=missing-confirmed still lists them). The admin asset list, Library review and ownership checks are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
After a library reorganisation, My Library listed books twice: once under their new file names, and again as unticked books under their old names. The old copies were files Dewarr had already marked
intentionally-removedormissing-confirmed, but the bookshelf (GET /api/library/books) still listed every copy Dewarr had ever seen. Title-family grouping could also pull a removed copy back in when its title matched a book still in the library.The change
CLOSED_STATESunless that state is asked for:?state=missing-confirmedstill lists them.Tests
tests/integration/test_library_browsing.pycovers removed and confirmed-missing copies, including a removed copy whose title matches a book still in the library.🤖 Generated with Claude Code