Skip to content

Leave removed and confirmed-missing copies off My Library - #86

Open
TheMightyTRex wants to merge 1 commit into
logabell:mainfrom
TheMightyTRex:contrib/library-hide-removed-copies
Open

TheMightyTRex wants to merge 1 commit into
logabell:mainfrom
TheMightyTRex:contrib/library-hide-removed-copies

Conversation

@TheMightyTRex

Copy link
Copy Markdown

The problem

After a library reorganisation, My Library listed books twice: once under their new file names, and again as unticked books under their old names. The old copies were files Dewarr had already marked intentionally-removed or missing-confirmed, but the bookshelf (GET /api/library/books) still listed every copy Dewarr had ever seen. Title-family grouping could also pull a removed copy back in when its title matched a book still in the library.

The change

  • The bookshelf leaves out copies in CLOSED_STATES unless that state is asked for: ?state=missing-confirmed still lists them.
  • The admin asset list, Library review and ownership checks are unchanged.

Tests

  • tests/integration/test_library_browsing.py covers removed and confirmed-missing copies, including a removed copy whose title matches a book still in the library.
  • Full server suite: 4,656 passed, 6 skipped.

🤖 Generated with Claude Code

…shelf

My Library listed every book Dewarr had ever seen a file for. After a library
reorganisation, files marked intentionally-removed or missing-confirmed showed
up as unticked books under their old file names, next to the same books under
their new names. Title-family grouping could also pull a removed copy back in
when its title matched a book still in the library.

The bookshelf (GET /api/library/books) now leaves out copies in
CLOSED_STATES unless that state is asked for (?state=missing-confirmed still
lists them). The admin asset list, Library review and ownership checks are
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant