Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grimmory 3.5.0's nested Spring paging response made even an empty Bookdrop queue fail folder verification. Library publication also failed when the destination root's inode changed after a write, and retry reused that stale identity.
Fixes NOR-98. Closes #65.
Refs NOR-94 and #61. Keep the Unraid report open for validation on the reporter's mount. NOR-82's remaining feature scope is unchanged.
Validation:
git diff --checkpassed. All tests ran serially throughpython3 scripts/check.py; no full suite.Limits and rollout: filesystem changes were simulated over real local files, not tested on live Unraid/cache-mover or a live Grimmory deployment. Marker file identity changes still require review; this does not trust the token alone. Stop old workers when upgrading so all writers use the new lock protocol. Storage behavior and recovery steps are documented in
docs/STORAGE-COMPATIBILITY.md.PR review follow-up
The shared library-review browser check could fail when “Save and review next” displayed the completed-link status and the next catalog-search status together. The fixture now holds that next lookup pending, checks both messages separately, and waits for the lookup to finish before continuing. The ambiguous assertion failed under this controlled timing before the fix; no product behavior or timeout was changed.
CI also found eight stale staging assertions that expected the destination root to contain only the private staging directory. They now require the persistent root marker as well, and verify that its bytes and inode survive both resume and cancellation. The failure reproduced locally before correction. Follow-up validation: 177 focused checks passed via
python3 scripts/check.py unit tests/unit/test_library_mount_staging.py tests/unit/test_destination_identity.py tests/unit/test_import_publication.py tests/unit/test_combine_parts.py; the library-review browser journey passed after the current production build. Existing live-mount limitations remain unchanged.