Skip to content

Fix catalog controls and Hardcover compatibility (NOR-88, NOR-91, NOR-100) - #71

Merged
logabell merged 2 commits into
mainfrom
logan/nor-88-custom-selectmenu-prevents-all-dropdowns-from-opening-in
Oct 15, 2026
Merged

logabell merged 2 commits into
mainfrom
logan/nor-88-custom-selectmenu-prevents-all-dropdowns-from-opening-in

Conversation

@logabell

@logabell logabell commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Hardcover author and series follows reject the provider's edition-list response, and editions reported as Listened are classified as unknown. Dropdown opening also suppresses the native picker even when the custom popover fails. This change repairs those boundaries and adds the same edition-format filter to discovery and saved books.

  • Replace the follow query's unsupported editions_aggregate with a bounded one-edition existence lookup, validate the response, and distinguish schema errors from explicit permission/scope errors.
  • Open custom dropdowns synchronously before suppressing native input. Use explicit dismissal so the opening pointer gesture cannot immediately close the popover; preserve native fallback, keyboard/touch/modal behavior, and disabled option groups.
  • Map Hardcover's Listened format to audio. Filter saved editions in the API before counting/pagination, reset pages when changing format, and explain incomplete provider lists. Regenerate the API contract.

Fixes NOR-91
Fixes #58
Related: NOR-88, #55, NOR-100, #67

Validation

All runs used python3 scripts/check.py, serially, on an isolated PostgreSQL 18 database where needed.

  • 67 backend checks passed: new provider-to-worker and provider-to-catalog journeys, metadata/cache/privacy regressions, follow preservation/ownership, and focused parser/adapter tests.
  • 16 Chromium journeys passed: dropdown pointer/keyboard/touch/modal behavior; failed/canceled/unsupported popovers and forced colors; edition filters across discovery, saved, and unlinked books; existing catalog-reader, settings-policy, and quick-add-source journeys.
  • 9 Firefox journeys passed: dropdown and edition-filter cases. One touch-emulation case was skipped because Playwright Firefox does not support it; Chromium exercised that case.
  • Frontend production build/typecheck, changed-file Ruff/Prettier, API generation, and whitespace checks passed.
  • Before the fixes, current-schema follow parsing, Listened format mapping, and failed-popover fallback each reproduced a failing regression.

Evidence and limits

On 2026-10-15, the reported Hardcover edition exposed book ID 602482, edition ID 31639613, ISBN 9798890553157, and readingFormat.format: "Listened" in its public page data while displaying “Audiobook.” The regression replays those facts through identifier lookup, cached fetch, import, and the edition API.

The reporter's authenticated API response and complete 49-edition snapshot were unavailable. Misclassification is confirmed; disappearance from the unfiltered list is not independently explained, and no speculative pagination fix is included. Existing saved edition identity changes retain the normal metadata refresh/review path.

The general mouse failure did not reproduce on the installed Chromium; the unusable failed-popover path did. Real pointer, keyboard, and fallback cases now pass in Chromium and Firefox. Microsoft Edge was not installed. Authenticated live Hardcover follow requests were not run; reported current-schema responses were replayed through the real parser and synchronization worker.

Scope: Dewarr: Catalog browsing and controls, based on origin/main at 371ed7c. Existing integration work in the main checkout and release-matching PR #70 were left untouched.

PR review follow-up

The shared library-review browser check could fail when “Save and review next” displayed the completed-link status and the next catalog-search status together. The fixture now holds that next lookup pending, checks both messages separately, and waits for the lookup to finish before continuing. The ambiguous assertion failed under this controlled timing before the fix; no product behavior or timeout was changed.

Follow-up validation: production build/typecheck and 8 Chromium journeys passed via python3 scripts/check.py ui library-review.spec.ts select-menu.spec.ts, including pointer, keyboard, touch, modal and native-fallback cases.

@linear-code

linear-code Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

NOR-91

NOR-100

NOR-88

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T05:35:22.239927Z d8eb9a9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@logabell
logabell merged commit 73c862f into main Oct 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardcover author follows fail because editions_aggregate is no longer in the books schema

1 participant