Repository navigation
Fix catalog controls and Hardcover compatibility (NOR-88, NOR-91, NOR-100) - #71
Merged
logabell merged 2 commits intoOct 15, 2026
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcover author and series follows reject the provider's edition-list response, and editions reported as
Listenedare classified as unknown. Dropdown opening also suppresses the native picker even when the custom popover fails. This change repairs those boundaries and adds the same edition-format filter to discovery and saved books.editions_aggregatewith a bounded one-edition existence lookup, validate the response, and distinguish schema errors from explicit permission/scope errors.Listenedformat to audio. Filter saved editions in the API before counting/pagination, reset pages when changing format, and explain incomplete provider lists. Regenerate the API contract.Fixes NOR-91
Fixes #58
Related: NOR-88, #55, NOR-100, #67
Validation
All runs used
python3 scripts/check.py, serially, on an isolated PostgreSQL 18 database where needed.Listenedformat mapping, and failed-popover fallback each reproduced a failing regression.Evidence and limits
On 2026-10-15, the reported Hardcover edition exposed book ID 602482, edition ID 31639613, ISBN 9798890553157, and
readingFormat.format: "Listened"in its public page data while displaying “Audiobook.” The regression replays those facts through identifier lookup, cached fetch, import, and the edition API.The reporter's authenticated API response and complete 49-edition snapshot were unavailable. Misclassification is confirmed; disappearance from the unfiltered list is not independently explained, and no speculative pagination fix is included. Existing saved edition identity changes retain the normal metadata refresh/review path.
The general mouse failure did not reproduce on the installed Chromium; the unusable failed-popover path did. Real pointer, keyboard, and fallback cases now pass in Chromium and Firefox. Microsoft Edge was not installed. Authenticated live Hardcover follow requests were not run; reported current-schema responses were replayed through the real parser and synchronization worker.
Scope:
Dewarr: Catalog browsing and controls, based onorigin/mainat371ed7c. Existing integration work in the main checkout and release-matching PR #70 were left untouched.PR review follow-up
The shared library-review browser check could fail when “Save and review next” displayed the completed-link status and the next catalog-search status together. The fixture now holds that next lookup pending, checks both messages separately, and waits for the lookup to finish before continuing. The ambiguous assertion failed under this controlled timing before the fix; no product behavior or timeout was changed.
Follow-up validation: production build/typecheck and 8 Chromium journeys passed via
python3 scripts/check.py ui library-review.spec.ts select-menu.spec.ts, including pointer, keyboard, touch, modal and native-fallback cases.