Repository navigation
Conversation
- Treat undetermined file languages (und, zxx, mul, mis) as absent tags, so an M4B whose only language marker is the MP4 default `und` no longer fails with "The files use a different language". - Ignore OS metadata files (.DS_Store, ._*, Thumbs.db, desktop.ini, ...) when checking structural destination folders, and name the folder and files when a real file does block publishing. - Say how much disk space is free, needed and reserved when a download waits for space, and where the reserve is configured. - Return an accurate 409 when a download is started while automatic import is only requested (unverified route) instead of "approval changed". Refs logabell#109, logabell#110 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Four small fixes for the dead ends described in #110 (and the first one from #109). Each one stopped a first download with a message that named the wrong cause or gave no next step.
The files use a different languagefor an M4B whose only language marker is the MP4 stream defaultundund,zxx,mulandmisare treated like an absent tag. Real languages (e.g.fragainst an English book) still conflict.A structural destination folder already contains fileswhen the author folder held only a macOS.DS_Store.DS_Store,._*,Thumbs.db,desktop.ini,.localizedand.directoryare ignored in structural ancestors. When a real file blocks publishing, the message names the folder and up to three files.Waiting for free disk space after existing reservations and reserveWaiting for free disk space: 645.0 GiB free after reservations, 1.0 GiB needed, 870.4 GiB kept in reserve (Settings → Download clients → Storage reserve)409 Automatic import approval changed; review this importwhen a download starts while automatic import is only requested (unverified route)409 Automatic import is not active for this library folder. Verify its download folder in Settings → Libraries, then turn automatic import onChange 4 only touches
approve_route()(download dispatch).check_policy()and its "approval changed" messages are untouched, so the generation/approver/recovery cases and their tests behave as before.Not included
Tests
size_label.python3 scripts/check.py unitontest_import_publication,test_linked_download,test_capacity_rules,test_automatic_content,test_automatic_eligibility,test_smb_publication: 341 passed.ruff checkandruff format --checkclean.test_publication_preserves_original_and_keeps_receipts_outside_library[hardlink]fails on main on an overlay/shfs temp directory ("Item contains missing or unplanned files") and passes on tmpfs (TMPDIR=/dev/shm). It fails the same way without this change.Refs #109, #110
🤖 Generated with Claude Code