Repository navigation
fix(ci): match the FLASH_ATTN pin as a fixed string, not a BRE - #3390
Merged
mudler-agent merged 1 commit intoOct 17, 2026
Merged
Conversation
phantomic12
force-pushed
the
fix/vulkan-ci-grep-bre-fix
branch
from
October 4, 2026 23:03
b1c3530 to
6a5e27b
Compare
The `prio[0]` pin landed in 16086ae (localai-org#3375) under a bare `grep -q`, so grep read it as a BASIC REGULAR EXPRESSION in which `[0]` is a character class for the digit 0. The pattern therefore asked for `prio0` and could never match the literal `prio[0]` doctest prints under `-s`. The pin was unsatisfiable from the moment it landed. Run 37160385766 on main is the evidence, and it separates the suite from the gate cleanly: the case ran, all thirteen assertions printed `is correct!`, and the summary read `test cases: 1 | 1 passed | 0 failed | 45 skipped` with `Status: SUCCESS!` — yet the step exited 1, because the SUITE passed and the GREP could not succeed. So `build-test-vulkan` has been red on main since 2026-10-02 while measuring a perfectly healthy device. `-qF` compares the literal text. Replaying all three pins against that run's captured `vulkan-platform-case.log` gives pin2 exit 1 before and exit 0 after, with pin1 and pin3 unchanged at 0; a deliberately wrong `prio[1]` string is still rejected, so the pin keeps its teeth. This is the only unsatisfiable pin in the file: the remaining bracketed pins (1908-1910, 1944-1945) are `-qE` and use `[[:space:]]`/`[1-9]`/`[0-9]` as intended classes. FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:buffy/space-bunny-alpha [freebuff]
phantomic12
force-pushed
the
fix/vulkan-ci-grep-bre-fix
branch
from
October 12, 2026 23:08
6a5e27b to
9adfd7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is broken
The
prio[0]pin in thebuild-test-vulkancase-gate step is unsatisfiable.It landed in
16086ae1f(#3375) under a baregrep -q, so grep parsed it as aBASIC REGULAR EXPRESSION in which
[0]is a character class for the digit0.The pattern asks for
prio0and can never match the literalprio[0]thatdoctest prints under
-s. The pin could not succeed from the moment it landed.#3375 correctly retired two stale pins. It replaced one of them with a third
failure mode: not stale wording, but a pattern that no output can satisfy.
Evidence — the suite passed and the GREP could not
Run
37160385766on
main@33fb82b09failsbuild-test-vulkanat The Vulkan suite MEASURED adevice rather than skipping past one, and its log separates cause from symptom:
Every assertion passed, the summary is green, the Vulkan device was genuinely
measured — and the step still exits 1, because the gate cannot be satisfied. The
lane has been red on
mainsince 2026-10-02 while proving something true.Replaying that run's captured
vulkan-platform-case.logthrough the three pins:CHECK_FALSE( p.get_device_capability().present() ) is correctCHECK( prio[0] == "FLASH_ATTN" ) is correcttest cases: *1 | *1 passedThe fix
-qF, so grep compares literal text. No other pin moves.This is the only unsatisfiable pin in the file:
git grepover.githubfindsthe remaining bracketed pins at 1908-1910 and 1944-1945, and those are
-qEusing
[[:space:]],[1-9]and[0-9]as intended character classes.Negative control
A fixed-string pin that matches everything is worthless, so: a deliberately wrong
CHECK( prio[1] == "FLASH_ATTN" ) is correct!is still rejected (exit 1).The pin keeps its teeth.
Honest gaps
machine; there is no GPU and no toolchain here, so no build was run. The log is
the real output of the run cited above.
python3 scripts/check-commit-style.pyandpython3 scripts/check-commit-trailers.pyoverupstream/main..HEAD: pass..github/workflows/ci.ymlre-parses with PyYAML (19 jobs).cannot fail for the right reason cannot show that. This PR restores the
ability to ask the question; the surrounding Windows and CPU lanes are red on
mainindependently of it and are untouched here.Update (2026-10-04): rebased onto
e67a071a6; main reached the same line independentlyThe PR went CONFLICTING when main advanced past
33fb82b09. It is nowrebased (head
6a5e27ba9), clean, and its two gates re-run at rc=0 overupstream/main..HEAD.One fact a reviewer should have: main already fixed this same defect in
ded529eef("ci: escape the prio bracket in the vulkan platform-case grep"),after run
37202846607hit the identical signature on PR #3393's head — green suite, then exit 1 at
the platform-case step — as its commit message records. The two fixes are
behaviorally equivalent; this PR keeps the
-qFform because a fixed stringhas no escaping to rot the next time the pin's text is edited, and it carries
the failure-mode comment quoted above in place of the three-line escape note.
Sections What is broken and Evidence describe main @
33fb82b09as offiling and are left unchanged; main's
e67a071a6CI run was still queued atthe time of this update.
FOLLOWING_AGENTS_PROTOCOL
Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: AGENT:buffy/space-bunny-alpha [freebuff]