feat: add pre-commit hook for automatic diagnostic generation#332
Open
feng83232 wants to merge 1 commit into
Open
feat: add pre-commit hook for automatic diagnostic generation#332feng83232 wants to merge 1 commit into
feng83232 wants to merge 1 commit into
Conversation
Owner
|
Diagnostics are still blocking review on this PR. Please rebase onto the current upstream branch and run the repository build script so the script-generated diagnostic bundle is committed to this PR: git fetch upstream
git rebase upstream/main
python3 build.py
git push --force-with-leasePlease do not manually create, copy, or edit diagnostic files. A valid PR must include a matching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89
This PR adds a pre-commit hook that runs diagnostic generation before every commit:
tools/pre-commit— Python hook that:python3 build.py --module frontendMakefile(new) — root-level Makefile withinstall-hookstargetdocs/pre-commit-hook.md(new) — usage and troubleshooting documentationInstall with:
make install-hooks