Harden browser sync against untrusted servers and recovery kits - #7
Open
lobbystack wants to merge 2 commits into
Open
lobbystack wants to merge 2 commits into
lobbystack wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser sync now rejects hostile or malformed input from the sync server, device bundles, and recovery kits instead of trusting it.
hasMorewith no envelopes.openBundlechecks that the signing seed and X25519 secret actually generate the stored public keys.unmapped, so they can decrypt operations but never own a local file or attachment. Importing a kit into a browser workspace already bound to a different remote workspace is refused.redirect: 'error', so the server can't bounce requests to another origin.Verification
Ran the package against a malicious local HTTP server and the real native recovery-kit fixture, before and after this change:
hasMorekey page / out-of-order / repeating cursor / 101 keysunmappedflagunmapped: trueAfter merging
main:browser-synctypecheck and 165 tests pass,apps/appcheck and 53 browser-sync tests pass, and 121local-coresync tests pass.Reviewer notes
fetchbuffers a server stream regardless of the reader, so the size bound only limits memory in browsers. This package targets the browser.🤖 Generated with Claude Code