Repository navigation
smite-ir: add Reconnect operation - #283
Open
NishantBansal2003 wants to merge 1 commit into
Open
NishantBansal2003 wants to merge 1 commit into
NishantBansal2003 wants to merge 1 commit into
Conversation
Add an IR `Operation::Reconnect` that closes the transport, re-runs the Noise handshake, and re-exchanges `init` with the originally negotiated features. `NoiseConnection` gains `reconnect`, backed by a new `Connector` that retains the dial parameters. On reconnect the executor discards every negotiation and channel that had not received `funding_signed`, matching what the target retains across a BOLT 2 reconnection. Replace `PendingChannel::funding_built: bool` with `funded_channel_id: Option<ChannelId>`, which drives the pruning and the existing `temporary_channel_id`-reuse checks. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
Member
Author
|
With This could hurt fuzzing efficiency somewhat. Some possible solutions I can think of are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an IR
Operation::Reconnectthat closes the transport, re-runs the Noise handshake, and re-exchangesinitwith the originally negotiated features.NoiseConnectiongainsreconnect, backed by a newConnectorthat retains the dial parameters.On reconnect the executor discards every negotiation and channel that had not received
funding_signed, matching what the target retains across a BOLT 2 reconnection.Replace
PendingChannel::funding_built: boolwithfunded_channel_id: Option<ChannelId>, which drives the pruning and the existingtemporary_channel_id-reuse checks.