Repository navigation
bolt: derive v2 channel ids from revocation basepoints - #278
Merged
Merged
Conversation
morehouse
approved these changes
Oct 12, 2026
morehouse
left a comment
morehouse
left a comment
Collaborator
There was a problem hiding this comment.
I verified all the expected-value tests against LDK and got the same results.
Please add a comment to each relevant test explaining that the expected values were computed by LDK.
BOLT 2 derives both the temporary_channel_id and the channel_id of a dual-funded channel from revocation basepoints rather than from the funding outpoint.
erickcestari
force-pushed
the
v2-channel-id
branch
from
October 13, 2026 14:54
8b6624d to
59bae67
Compare
Member
Author
Added! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOLT 2 derives both the
temporary_channel_idand thechannel_idof a dual-funded channel from revocation basepoints rather than from the funding outpoint.This is part of breaking down PR #239 into smaller PRs to make them easier to review.