smite: track commitment state per side - #275
Open
NishantBansal2003 wants to merge 1 commit into
Open
NishantBansal2003 wants to merge 1 commit into
NishantBansal2003 wants to merge 1 commit into
Conversation
Commitments are asymmetric: after an update, each side's commitment can have a different commitment number, fee rate and balances until both sides catch up. Replace the single shared CommitmentState with ChannelCommitments, which holds one state per side, each with its own local_side and per_commitment_point. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
NishantBansal2003
force-pushed
the
asymmetric-commitment
branch
from
October 4, 2026 12:07
caa4358 to
eab47a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commitments are asymmetric: after an update, each side's commitment can have a different commitment number, fee rate and balances until both sides catch up. Replace the single shared
CommitmentStatewithChannelCommitments, which holds one state per side, each with its ownlocal_sideandper_commitment_point.