smite-scenarios: handle channel_ready implicitly on receive - #265
Open
NishantBansal2003 wants to merge 1 commit into
Open
NishantBansal2003 wants to merge 1 commit into
NishantBansal2003 wants to merge 1 commit into
Conversation
The target can send channel_ready before a message we're explicitly waiting for, so recv_non_ping now records it into channel_states and explicit receives skip past it instead of failing. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow the executor to avoid halting when
channel_readyis received in the middle of another negotiation. It would also be useful for HTLC fuzzing once we add implicit handling ofcommitment_signedandrevoke_and_ack.The reason for splitting
recv_implicit_boltandrecv_explicit_boltis that explicitly handled message types do not care about implicitly handled messages, so when receiving one, we can simply skip those. For implicitly handled message types, however, check a precondition when the specific implicit message is received before receiving the next message. This split helps separate those drains based on that behavior