Upon encountering an error, most functions in smitebot currently log the error and return false. This is non-idiomatic and leads to more lines of code than necessary.
Instead we should return the error and let the caller log it if necessary. This allows us to use the ? operator widely and centralizes the logging, which should improve readability and reduce LoC.
Upon encountering an error, most functions in smitebot currently log the error and return
false. This is non-idiomatic and leads to more lines of code than necessary.Instead we should return the error and let the caller log it if necessary. This allows us to use the
?operator widely and centralizes the logging, which should improve readability and reduce LoC.