Add Tahoma font support with priority font loading and fonts package …#206
Open
awgzauharybinagomar wants to merge 1 commit into
Open
Conversation
…dependency - Update _get_font() to try Tahoma.ttf first before falling back to DejaVuSans-Bold and Arial Bold - Add 'fonts>=1.0' dependency to provide Tahoma and other common TrueType fonts - Maintains backwards compatibility with existing font fallback chain
Member
|
Thanks @awgzauharybinagomar. This PR is a smaller, earlier version of the same Tahoma-font work proposed in #207. Both can't merge. I've left detailed comments on #207. Could you decide which approach you want to push forward (the minimal change here vs. the fuller Note also the Tahoma redistribution-license question I raised on #207 — that applies here too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dependency