Conversation
Signed-off-by: Guangya Liu <gyliu513@gmail.com>
github-actions
Bot
added
size/L
|
This PR is marked as stale after 21d of inactivity. After an additional 14d of inactivity (7d to become rotten, then 7d more), it will be closed. To prevent this PR from being closed, add a comment or remove the |
JaredTan95
reviewed
Sep 25, 2026
| os.Setenv("OTEL_EXPORTER_OTLP_ENDPOINT", "http://localhost:4317") | ||
| } | ||
|
|
||
| traceExporter, err := otlptracegrpc.New(ctx, otlptracegrpc.WithInsecure()) |
Member
There was a problem hiding this comment.
How about following the approach of llm-d-router? Explicitly pass WithInsecure() only when there are no transport environment variables, otherwise pass nil to let the SDK read from the environment itself.
Member
There was a problem hiding this comment.
or we can impl it in a separate PR
JaredTan95
added a commit
to JaredTan95/llm-d-inference-payload-processor
that referenced
this pull request
Sep 25, 2026
The resource was built with resource.NewWithAttributes, which does not run any environment detectors, so the OTEL_SERVICE_NAME variable (written via os.Setenv) and OTEL_RESOURCE_ATTRIBUTES were never read: service.name was missing from every trace. Build the resource with resource.New + resource.WithFromEnv() instead, mirroring llm-d-router. OTEL_SERVICE_NAME and OTEL_RESOURCE_ATTRIBUTES now override the built-in defaults, and a malformed OTEL_RESOURCE_ATTRIBUTES degrades to a partial resource with a report rather than stopping startup. This is a separate, independent fix from the OTEL_TRACES_EXPORTER support in llm-d#306 and does not touch the exporter code. Signed-off-by: JaredTan95 <jian.tan@daocloud.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #305
Release note (write
NONEif no user-facing change):/cc @nirrozenbaum