Conversation
Store plugin-shared data directly on InferenceRequest via a sync.Map attribute store, matching EPP's pattern. Pass request to response plugin signatures so they can read attributes set during request phase. Delete cycle_state.go entirely. Signed-off-by: szedan <szedan@redhat.com>
Replace json.RawMessage with *json.Decoder in FactoryFunc and all 16 factory implementations. Config loader now wraps parameters via StrictDecoder (imported from EPP) to enable DisallowUnknownFields validation on plugin config parsing. Closes llm-d#293 Signed-off-by: szedan <szedan@redhat.com>
github-actions
Bot
added
size/L
ArshVermaGit
left a comment
ArshVermaGit
left a comment
There was a problem hiding this comment.
Small cleanup change aligning FactoryFunc with the EPP json.Decoder interface. The change is focused and looks good to me.
nirrozenbaum
left a comment
nirrozenbaum
left a comment
There was a problem hiding this comment.
@szedan-rh the PR mixes the removal of CycleState with the replacement of json decode function.
please align the changes with the purpose of the PR (update json decode)
|
Thanks for flagging this @nirrozenbaum you're right, and here's why it happened: this branch (szedan-rh/293-factoryfunc-json-decoder) was stacked on top of szedan-rh/288-request-attributes-remove-cyclestate (#294), so the diff against main is picking up both the CycleState removal from #294 and the FactoryFunc/json.Decoder change that's actually in scope here. Plan to fix: once #294 merges, I'll rebase this branch onto the updated main, which will drop the CycleState-related commits from this diff and leave only the json.RawMessage → *json.Decoder change that closes #293. Will ping this thread once that's done so it's clean for re-review. |
|
This PR is marked as stale after 21d of inactivity. After an additional 14d of inactivity (7d to become rotten, then 7d more), it will be closed. To prevent this PR from being closed, add a comment or remove the |
3 participants
/kind cleanup
Align FactoryFunc signature with EPP: json.RawMessage → *json.Decoder
Replace json.RawMessage with *json.Decoder in FactoryFunc and all 16
factory implementations. Config loader now wraps parameters via
StrictDecoder (imported from EPP) to enable DisallowUnknownFields
validation on plugin config parsing.
Closes #293