Skip to content

Add frontend quality checks - #169

Merged
llbbl merged 3 commits into
masterfrom
feature/issue-120-frontend-checks
Sep 13, 2026
Merged

llbbl merged 3 commits into
masterfrom
feature/issue-120-frontend-checks

Conversation

@llbbl

@llbbl llbbl commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Closes #120

Summary

  • Add Biome 2.5 warning-free formatting and linting with full Vue and Svelte support.
  • Add svelte-check and vue-tsc static checks plus a dedicated frontend pull-request CI job.
  • Document frontend quality commands and the tool split for contributors.

Changes

Frontend Quality Tooling

  • biome.json: Configure repository-wide Biome formatting and linting with warnings treated as errors.
  • svelte.config.js: Configure Svelte component checking.
  • tsconfig.vue.json: Configure Vue component checking with vue-tsc.
  • package.json / pnpm-lock.yaml: Add Biome, Svelte/Vue checks, and package scripts.
  • .github/workflows/ci.yml: Add the frontend quality job to pull-request CI.

Initial Cleanup and Documentation

  • src/js/, src/vue/, src/svelte/: Apply the initial codebase formatting pass and safe lint cleanups required for warning-free checks.
  • vite.config.js, playwright.config.ts, e2e/, bench/: Apply compatible formatting and safe lint fixes in existing JavaScript/TypeScript support code.
  • docs/contributing.md: Document Biome, svelte-check, and vue-tsc commands and their responsibilities.

Validation

  • Frozen-lock install
  • pnpm check with Biome warnings-as-errors
  • pnpm build
  • 166 unit tests / 497 assertions
  • 10 integration tests / 56 assertions
  • 1 WebSocket integration test / 8 assertions
  • PHPStan
  • PHP CS check
  • Full Playwright suite: 5/5
  • Composer audit
  • pnpm audit --prod
  • Git diff check
  • Two independent reviews passed

.github/workflows/mutation.yml is unchanged and remains manual-only through workflow_dispatch; mutation testing was not added to automatic pull-request CI.

@socket-security

socket-security Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​typescript@​6.0.31001009010090
Addednpm/​vue-tsc@​3.3.111001009197100
Addednpm/​svelte-check@​4.7.69910010097100
Addednpm/​@​biomejs/​biome@​2.5.1310010010099100

View full report

@llbbl
llbbl merged commit 2a48c1f into master Sep 13, 2026
7 checks passed
@llbbl
llbbl deleted the feature/issue-120-frontend-checks branch September 13, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Biome for JS/Vue/Svelte linting and formatting

1 participant