Repository navigation
Add local sync - #153
Merged
Merged
Add local sync#153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to sync two windows in the
inkflow buildscenario. Since there is no server in that case and it is supposed to work when opening the built html file viafile://, the underlying mechanism has to be different from theservecase where websockets handle communication.In the offline case, the clicking the new status bar button will open a second tab that will be connected to the first one. Syncing works the same way as online then including the sync direction settings with the only limitations being that you can only over connect two tabs/windows (which is what you'd usually want) and that you have to use the button. Simply opening typing the same url twice (which works in
serve) will not sync.