Fix plain-text placement preview to match selected text size and zoom#178
Open
lklyne wants to merge 1 commit into
Open
Fix plain-text placement preview to match selected text size and zoom#178lklyne wants to merge 1 commit into
lklyne wants to merge 1 commit into
Conversation
The ghost-text preview shown when hovering with the add-text tool was hardcoded to 12px and ignored canvas zoom. Now it reads the configured text size from tool defaults and scales it by the canvas zoom level, so the preview matches the text that will actually be created. Closes #146 https://claude.ai/code/session_013KdAUApa9UExU6LhjCt6Vr
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146
What changed
The ghost-text preview shown when hovering with the add-text tool was hardcoded to
12pxand ignored canvas zoom. This fix makes the preview reflect both the configured text size and the current zoom level.Changes
src/shared/types.ts— added optionaltextSize?: numberfield toPendingPlacementsrc/main/runtime/canvas-layout-data.ts—buildPlacementPreviewnow readsgetToolDefaults()['add-text'].textSizeand includes it in the placement foradd-texttoolssrc/renderer/canvas-bg/canvasBgSelectors.ts—buildPendingPlacementPreviewpassestextSizeandzoomthrough to the preview objectsrc/renderer/canvas-bg/CanvasGridSurface.tsx—PlacementPreviewLayernow computesscaledFontSize = textSize * zoomfor the plain-text case instead of using the hardcodedtext-[12px]Tailwind classAcceptance criteria check
Generated by Claude Code