Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 55.43% 4.43% -51.01%
==========================================
Files 18 18
Lines 1407 1420 +13
==========================================
- Hits 780 63 -717
- Misses 627 1357 +730 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this not showing up in Aqua because the ambiguity only is there if CUDA is loaded? |
|
Yes basically exactly that. |
|
lol "amgiguating" |
|
Annoying, more ambiguities to fix. |
e5d63ac to
6f44092
Compare
|
OK, I think this is ok to go (but we'll want to fix |
|
OK, created a more specific |
6f631e0 to
b6ed4ee
Compare
|
I think everything got resolved here? |
| inds = findall(!iszero ∘ last, B_ends) | ||
| isempty(inds) && return zero(TKscalartype(t)) | ||
| return only(last(B_ends[only(inds)])) | ||
| end |
There was a problem hiding this comment.
| end | |
| function TO.tensorscalar(t::AbstractBlockTensorMap{T, S, 0, 0}) where {T, S} | |
| return prod(TO.tensorscalar, nonzero_values(t)) |
Do you know if this would work?
There was a problem hiding this comment.
Let me try it locally and get back to you
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
This seems to be needed for conversion of
BlockTensorMaps backed by GPU arrays toCuTensorMap-- otherwise an ambiguity error arises.