Draft
Conversation
580b501 to
5321c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "bring your own workspace" Dockerfile for ComfyStream (
Dockerfile.byow), adds comprehensive documentation for this workflow, and updates the base Dockerfile to use newer versions of ComfyUI and ComfyUI-Manager. It also improves environment setup, dependency management, and integration with ComfyStream, while updating references to Livepeer documentation. The server code is updated to blacklist theComfyUI-Managernode during inference for compatibility.New bring-your-own-workspace workflow:
Dockerfile.byowto support mounting and managing a user’s own ComfyUI workspace, including custom nodes and models. The Dockerfile sets up a virtual environment usinguv, installs dependencies, and integrates ComfyStream automatically.docker/entrypoint-byow.shto handle workspace setup, virtual environment activation, and conditional launching of ComfyUI or custom commands.README-BYOW.mdwith detailed instructions for building, running, and troubleshooting the bring-your-own-workspace container.Base image and dependency updates:
docker/Dockerfile.baseto use ComfyUI v0.3.60 and install ComfyUI-Manager, ensuring compatibility with new features and workflows. Also installs ComfyUI-Manager requirements. [1] [2]pyproject.tomlto use a newer version of ComfyUI from the hiddenswitch fork.Server compatibility and documentation:
server/app.pyandserver/frame_processor.pyto blacklist theComfyUI-Managernode during inference, preventing potential issues with custom node execution. [1] [2]README.mdto reference the Livepeer fork and documentation, reflecting the project’s migration and providing accurate installation instructions. [1] [2]