add support for presigned SAS tokens for Azure blob store#21
Draft
chenosaurus wants to merge 1 commit into
Draft
add support for presigned SAS tokens for Azure blob store#21chenosaurus wants to merge 1 commit into
chenosaurus wants to merge 1 commit into
Conversation
Contributor
biglittlebigben
left a comment
biglittlebigben
left a comment
There was a problem hiding this comment.
No real comment on the actual SAS token part, but some nits. Also while the test for this package are currently pretty sparse, this may be an opportunity to (ask Claude to) write one for the new functionality.
| switch { | ||
| case sasToken != "": | ||
| if conf.AccountKey != "" { | ||
| logger.Warnw("azure: both account_key and sas_token configured, using sas_token", nil) |
Contributor
There was a problem hiding this comment.
We usually do not log warnings for bad user provided input. Even less so here where there is no actual failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.