Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/commands/launch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ pub struct LaunchCommand {
#[arg(long)]
pub new: bool,

/// Start without attaching the terminal (run in the background).
/// Attach the terminal to stream debug logs (default: runs detached).
#[arg(long)]
pub detach: bool,
pub attach: bool,

/// Import a Jupyter notebook (.ipynb) file on launch.
#[arg(long, value_name = "PATH")]
Expand Down Expand Up @@ -147,7 +147,7 @@ pub async fn execute(cmd: LaunchCommand, ctx: &mut CommandContext<'_>) -> Result
.register_session(session_record.clone(), runtime_env)
.await?;
let launch_handle = supervisor
.launch_session(&session_record.id, cmd.detach, ctx.config)
.launch_session(&session_record.id, !cmd.attach, ctx.config)
.await?;

let SessionLaunchHandle {
Expand Down Expand Up @@ -199,7 +199,7 @@ pub async fn execute(cmd: LaunchCommand, ctx: &mut CommandContext<'_>) -> Result
.warn(format!("Unable to prepare editor URL: {err}"))?;
}

if cmd.detach {
if !cmd.attach {
if let Some(event) = completion_rx.borrow().clone() {
match handle_completion_event(event, &supervisor, &session_record.id, ctx).await? {
CompletionOutcome::Finished => return Ok(()),
Expand Down
10 changes: 5 additions & 5 deletions versions.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@
"python_runtime": "3.12",
"components": {
"livedocs": "1.0.0-rc.19",
"livedocs-jedi": "1.0.0-rc.7",
"middleman": "1.0.0-rc.22"
"livedocs-jedi": "1.0.0-rc.8",
"middleman": "1.0.0-rc.23"
}
},
"stable": {
"cli_version": "1.0.4",
"cli_version": "1.1.1",
"python_runtime": "3.12",
"components": {
"livedocs": "1.0.4",
"livedocs-jedi": "1.2.0",
"middleman": "1.3.0"
"livedocs-jedi": "1.2.1",
"middleman": "1.3.1"
}
}
}
Expand Down
Loading