docs(#97): ADR for toolCalls vs skillCalls index contract#99
Merged
Conversation
Record why toolCalls stays a plain {toolName:count} dashboard contract
and per-skill detail lives in a separate skillCalls index, so a future
"merge the two fields" change doesn't repeat the dashboard breakage from
PR #94. Also documents why skillCalls is structurally Anthropic-only.
Cross-linked from docs/normalization-map.md §5.
Closes #97
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
docs/decisions/0001-toolcalls-vs-skillcalls.md— a lightweight ADR recording whytoolCallsandskillCallsare kept as two separate index fields, and cross-links it fromdocs/normalization-map.md§5.Why
toolCalls({toolName: count}) is a shared dashboard contract (tc['Skill'], tool chips, tool-utilization). An early PR #94 revision expandedSkill:<name>keys intotoolCalls, polluting that contract and breaking dashboard consumers. The fix added a separateskillCallsfield. That decision lived only in a commit message — this ADR captures it so a future "merge the two fields" change doesn't repeat the regression.Also documents why
skillCallsis structurally Anthropic-only: the Codex (OpenAI Responses) protocol has no skill-call concept (skills are prompt instructions, not tool calls).Verification
All references checked against the worktree code, not just the issue text:
extractToolCalls/extractSkillCalls—server/helpers.js:717,735skillCallspersisted —server/entry.js,server/wire-parsers/anthropic.js:56tc['Skill']—public/miller-columns.js:2336,2341(pre-tracking)degrade —server/usage.js:310Docs-only change; no code touched (no type-checker/tests apply).
Closes #97