Repository navigation
fix(search): open addresses typed without a scheme; keyboard no longer blurs the bar - #99
Merged
Merged
Conversation
…r blurs the bar - Both boxes (the bar and the new tab) only opened what began with https://, so "youtube.com" was sent to Google. resolveAddressInput now tells an address from a search: domains, localhost and IPs open (https, or http for local ones), anything with a space or a single word is searched, and file-looking endings such as config.json are searched too. - The controller keyboard's full-screen layer dimmed and blurred the address bar, hiding the text being typed. The layer is now transparent and only the keyboard panel takes the pointer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A script run in a page that is still navigating may never answer, so the new test timed out on the CI runners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://…as an address, soyoutube.comwent to Google.resolveAddressInput(src/shared/addressInput.ts, unit-tested) now decides:youtube.com,www.site.com.br/tv,site.com:8080/aopen withhttps://;localhost:3000and192.168.0.10open withhttp://;youtube), or a file-like ending (config.json) is searched;javascript:andfile:are searched, never opened.Both paths go through
Navigation.searchOrGo, so the new tab, the address bar and links from internal pages all follow the same rule.shortcut: no public-suffix list, so
word.letterswith an unknown ending opens as a site; the known file endings are excluded.Test plan
npm run typechecknpm test(109 passed)npm run test:e2e(50 passed, 3 skipped), with a new test for the new tab box🤖 Generated with Claude Code