Repository navigation
chore: remove every reference to MultiMonitorTool and SoundVolumeView - #119
Merged
Merged
Conversation
1.6 controls displays and audio with Windows' own APIs and bundles none of
the NirSoft tools, but the code, comments, tests and docs still named them.
- AppPaths no longer deletes the old tools from the tools folder at startup.
- Comments in CoreAudio, NativeDisplays, AudioNaming, DisplayIdentity and
ConsoleEngine now say what the formats are ("the format 1.5 saved") instead
of naming the tool that used to write them. The formats themselves do not
change, so settings and backups made by 1.5 keep working.
- Two test names that cited the tools are renamed; docs/TESTING.md drops the
check that the tools folder is cleaned.
Kept on purpose: the released changelog sections (they record what those
versions did) and THIRD_PARTY_NOTICES.md (the notice for the 1.5 releases that
did ship the tools).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes This review covers the removal of NirSoft-specific references and the associated legacy-file cleanup behavior.
- Code and test wording Rephrases comments and test names to describe the formats saved by version 1.5 without naming the former tools.
- Legacy-file cleanup Removes startup deletion of the old executables; the changelog documents that direct 1.5 upgraders retain them until manual removal.
- Manual testing docs Removes checks that depended on the old tool names and cleanup behavior.
GPT Luna ｜ 𝕏
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes This review covers the merge from main since the prior Pullfrog review.
- Package-cleanup note Added the note that only
rtss-cliis embedded to both changelogs, clarifying why leftover NirSoft executables are no longer included in the package.
GPT Luna ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes every reference to the NirSoft tools (MultiMonitorTool, SoundVolumeView) that the 1.6 own-code backends replaced.
AppPathsno longer deletes the old executables from the tools folder at startup.CoreAudio,NativeDisplays,AudioNaming,DisplayIdentityandConsoleEnginedescribe the formats ("the format 1.5 saved") instead of naming the tool. The formats do not change, so settings and backups made by 1.5 keep working.docs/TESTING.mddrops the check that the tools folder is cleaned.Heads-up
toolsfolder until they delete them by hand. The changelog says so. If that is not acceptable (they are flagged by some antivirus), the cleanup can stay as a name-agnostic or installer step instead.THIRD_PARTY_NOTICES.md(the notice for the 1.5 releases that did ship the tools).Verification
Built on Windows locally (Debug x64, 0 errors);
dotnet testpasses (151).git grepfinds no mention outside the two files above. Independent of the other open PRs (basemain); the changelog line may need a trivial rebase.🤖 Generated with Claude Code