Repository navigation
feat: configurable controller shortcuts with a first-run setup - #116
Merged
Merged
Conversation
The controller shortcuts were fixed: hold Home to open from the tray, Select + Y for the session menu and Start + Select to go back to the PC. Now the user picks each one, and none is on until they choose. - ControllerShortcuts holds the pure rules: which buttons a shortcut may use (Home, Select, Start, A, B, X, Y: the ones every pad reports, XInput and Sony HID alike), what a combo is called per pad, and which two shortcuts collide (the same combo, or one containing the other). A single face button is refused because it would fire in any game; only Home may stand alone. - ShortcutCapture records the combo from live pad readings: hold the buttons and let go. It only starts after a poll with nothing held, so the press that opened the capture is not recorded. - ShortcutPicker is the control used in Settings and in the first-run dialog. While a capture runs no shortcut fires and the pad does not navigate. - The first run of this version shows the setup once (after the tour, or when the window is first opened from the tray). Existing installs start with nothing set too, because the old Home/Start + Select settings are dropped. - The session hint toast and the "or hold ... to go back" line use the shortcut that was chosen, and the toast is skipped when the menu has none. The console rows toggle the suggested combo, since capturing needs the desktop Settings. Docs: README pair and a new section in docs/TESTING.md. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
A shortcut can be captured from multiple controllers even though XInput only fires it when one controller holds the entire combination.
Reviewed changes This review covers configurable controller shortcut capture, persistence, onboarding, and integration with the tray and session UI.
- Shortcut configuration Adds three saved shortcut slots, capture and conflict validation, and suggested combinations.
- First-run setup Prompts desktop users to configure or skip shortcuts after the tour or when opening from the tray.
- Shortcut behavior and UI Connects shortcuts to app launch, the session menu, and restore, and updates Settings, console hints, localization, and hardware test guidance.
GPT Luna ｜ 𝕏
…nto feat/custom-controller-shortcuts
Contributor
There was a problem hiding this comment.
Important
The new HID trust tracking can quarantine healthy controllers when another controller of the same model reports invalid input.
Reviewed changes Re-reviewed the commits since the prior Pullfrog review, focusing on per-device shortcut capture and the synchronized HID controller-trust changes.
- Scoped shortcut capture to one controller Separated device states during capture and made shortcut triggering check each controller independently, addressing the prior finding.
- Added HID input quarantine Incorporated consecutive invalid-reading detection and filtering of quarantined pads, alongside changes synchronized from
main.
GPT Luna ｜ 𝕏
|
|
||
| // A pad with impossible readings is ignored (see ControllerMapping.MaxSimultaneousHidButtons). | ||
| var pressedCount = buttons.Count(on => on); | ||
| NoisyStreaks.TryGetValue(name, out var streak); |
Contributor
There was a problem hiding this comment.
These trust maps use SafeName as the device key, but it contains only display name and vendor/product IDs. Two identical controllers therefore share their noise streak and quarantine state, so one defective pad can make its healthy sibling get ignored too.
Technical details
# HID trust state is shared by identical controllers
## Affected sites
- `src/ConsoleMode/Services/ControllerInput.cs:273-274` — `NoisyStreaks` and `DistrustedPads` are keyed by strings.
- `src/ConsoleMode/Services/ControllerInput.cs:281,303-308` — the shared display-name/vendor/product string is used as the key for both streak tracking and permanent quarantine.
## Required outcome
- Keep noisy streak and quarantine state isolated per physical HID device so one controller's invalid readings do not suppress another identical controller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Controller shortcuts become user-chosen: open Console Mode from the tray, the session menu, and back to the PC. None is on until the user picks it; the first run of this version shows a setup dialog (after the tour, or when the window is first opened from the tray). Existing installs start with nothing set too: the old Home / Start + Select settings are dropped.
ControllerShortcuts(pure, tested): allowed buttons (Home, Select, Start, A, B, X, Y, what every pad reports), naming per pad, and conflicts (same combo, or one containing the other). A lone face button is refused; only Home may stand alone.ShortcutCapturerecords a combo from live readings (hold and let go) and ignores the press that opened the capture.ShortcutPickeris the control used in Settings and in the setup dialog; while capturing no shortcut fires and the pad doesn't navigate.Verification
Built locally (0 errors);
dotnet testpasses (185, 30 new). The capture with a real pad is not automated: checklist indocs/TESTING.md(new section 0). Checked in the app with the mouse (set, remove, conflicts, persistence); a physical pad and a PlayStation pad were not exercised.Stacked on #115.
🤖 Generated with Claude Code