Repository navigation
fix: the session hint toast no longer sticks on screen - #114
Merged
Merged
Conversation
The toast that shows the menu shortcut a few seconds into a session was created with `_ = new SessionHintWindow(...)` and its close timer was a local variable. Nothing held either of them, so the garbage collector could take the window and the timer before the timer fired, and the toast then stayed on screen and never closed, only sometimes. The window now keeps itself in a static set until it closes and owns its timer; the timer stops itself when it fires and a failed Close goes to the log instead of being swallowed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes The session hint toast now retains its window and timer until the toast closes, with changelog and manual-test documentation updated.
- Toast lifecycle The window is held in a static set until
Closed, and its dispatcher timer closes it after the configured duration. - Verification guidance The Portuguese manual checklist covers repeated sessions and the changelog entries describe the user-visible fix.
GPT Luna ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The toast that shows the menu shortcut a few seconds into a session was created with
_ = new SessionHintWindow(...)and its close timer was a local. Nothing held either, so the GC could take the window and the timer before the timer fired: the toast then stayed on screen forever, only sometimes. The window now keeps itself in a static set until it closes and owns its timer; a failedCloseis logged.Verification
Built on Windows locally (Debug x64, 0 errors) and
dotnet testpasses (151). The GC-dependent behaviour cannot be unit tested: manual check added todocs/TESTING.md§1c (toast closes by itself in ~7 s, over several sessions).Stacked on #113.
🤖 Generated with Claude Code